Fix public timelines being broken by new toots when they are not mounted #10131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It certainly reduces issues, but what about when streaming fails, the timeline is updated, and the |
Gargron
force-pushed
the
fix-web-ui-public-timeline-bug
branch
from
a0dd411
to
1cc2c1e
Compare
ClearlyClaire
approved these changes
Mar 7, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #6876
The condition was returning true even when the timeline has not been loaded once before. Once a toot was posted, it would then be inserted into the timeline, and when the timeline is then opened, that toot would be sitting there alone, making it so the actual timeline loading would fetch only toots older than that toot, creating unnatural gaps.
This was a bad look for new users especially.