Support pushing and receiving updates to poll tallies #10209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
force-pushed
the
features/poll-updates
branch
5 times, most recently
from
29d705a
to
9fbc2b7
Compare
|
|
ClearlyClaire
force-pushed
the
features/poll-updates
branch
12 times, most recently
from
11ae11d
to
99ccb94
Compare
ClearlyClaire
force-pushed
the
features/poll-updates
branch
from
99ccb94
to
295530e
Compare
|
Does this mean that if you boost or vote in a poll you get a notification of the results when it closes? :o If so, I love that. |
|
@Cassolotl no, it only notifies the author of the poll. We could extend that to voters or people who boosted it, but I'm not sure we should do that (and it would be slightly trickier). Also, we need to change the code so that the new notification type isn't sent to unsupporting clients (it breaks some of them). |
|
Extended the notification to apply to all users who have voted, should handle both local and remote polls |
Gargron
approved these changes
Mar 10, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
* Process incoming poll tallies update * Send Update on poll vote * Do not send Updates for a poll more often than once every 3 minutes * Include voters in people to notify of results update * Schedule closing poll worker on poll creation * Add new notification type for ending polls * Add front-end support for ended poll notifications * Fix UpdatePollSerializer * Fix Updates not being triggered by local votes * Fix tests failure * Fix web push notifications for closing polls * Minor cleanup * Notify voters of both remote and local polls when those close * Fix delivery of poll updates to mentioned accounts and voters
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
…stodon#10246) * Fix poll update handler calling method was that was not available Fix regression from mastodon#10209 * Refactor VoteService * Refactor ActivityPub::DistributePollUpdateWorker and optimize it * Fix typo * Fix typo
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
* Process incoming poll tallies update * Send Update on poll vote * Do not send Updates for a poll more often than once every 3 minutes * Include voters in people to notify of results update * Schedule closing poll worker on poll creation * Add new notification type for ending polls * Add front-end support for ended poll notifications * Fix UpdatePollSerializer * Fix Updates not being triggered by local votes * Fix tests failure * Fix web push notifications for closing polls * Minor cleanup * Notify voters of both remote and local polls when those close * Fix delivery of poll updates to mentioned accounts and voters
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
…stodon#10246) * Fix poll update handler calling method was that was not available Fix regression from mastodon#10209 * Refactor VoteService * Refactor ActivityPub::DistributePollUpdateWorker and optimize it * Fix typo * Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updateactivities onQuestionobjects, treating them the same way as polling thoseQuestionshide_totalsunset has been processed, schedule a job to issue anUpdateto the audience of the poll (every mentioned user, everyone who has boosted the toot, everyone who has voted, and, if the poll is not a direct message, every follower). Only one job at a time can exist.Updateto the people listed above.