Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more visual issues with the audio player #11654

Merged
merged 2 commits into from
Aug 25, 2019
Merged

Fix more visual issues with the audio player #11654

merged 2 commits into from
Aug 25, 2019

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Aug 25, 2019

  • Add horizontal baseline in the middle of waveform
  • Fix audio player colors in light theme
  • Use audio element instead of web audio API
  • Do not render any bars until the file is loaded
  • Do not allow interactions with waveform until the file is loaded

@Gargron
Fix more visual issues with the audio player
35bd939 
- Add horizontal baseline in the middle of waveform
- Fix audio player colors in light theme
- Use audio element instead of web audio API
- Do not render any bars until the file is loaded
- Do not allow interactions with waveform until the file is loaded
@Gargron Gargron added the ui Front-end, design label Aug 25, 2019
@Gargron Gargron merged commit 2e99e3c into master Aug 25, 2019
@ykzts ykzts deleted the fix-audio-player-more branch August 25, 2019 13:17
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
@Gargron @hiyuki2578
Fix more visual issues with the audio player (mastodon#11654)
112458e 
* Fix more visual issues with the audio player

- Add horizontal baseline in the middle of waveform
- Fix audio player colors in light theme
- Use audio element instead of web audio API
- Do not render any bars until the file is loaded
- Do not allow interactions with waveform until the file is loaded

* Fix code style issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykzts ykzts ykzts approved these changes

Assignees
No one assigned
Labels
ui Front-end, design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gargron @ykzts