-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix “slow mode” issues #11859
Fix “slow mode” issues #11859
Conversation
ClearlyClaire
commented
Sep 16, 2019
- Do not scroll weirdly when clicking the “load pending items” button
- Treat pending items as unread items
The “X new items” click was interfering with the mouse movement scroll prevention behavior, which resulted in very weird scroll behavior. I fixed that. |
Is the mouse movement thing still necessary if scrolling down will add new stuff to pending items instead of pushing the feed down? |
yes, if you're still on top |
0b574cc
to
0b1041f
Compare
Pushed another commit preventing a scroll discrepancy I hadn't seen: when scrolled down and the “x new items” button appears, it pushed everything down and that wasn't corrected |
This reverts commit d28ca02 partially.
This reverts commit d28ca02.
…lly"" This reverts commit 82c4520.
… partially""" This reverts commit c4bb702.
* Fix weird scroll-jumping behavior with pending items * Treat pending items as unread items * Fix scroll position being altered because of the “X new items” button