Fix poll options not being selectable via keyboard #12538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
force-pushed
the
features/keyboard-poll-navigation
branch
from
369f4af
to
01d288b
Compare
Gargron
approved these changes
Dec 2, 2019
|
Fixed some coding style issues, but I'll keep the |
ClearlyClaire
force-pushed
the
features/keyboard-poll-navigation
branch
from
32d42a7
to
2e0f1a5
Compare
|
Nevermind, updated it to avoid that, since it can have negative performance implications. |
Gargron
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12384
Also allow switching from single-option to multiple-option poll with keyboard and add a tooltip explaining that.
Changes the styling of hovered/focused/active checkboxes/radios as following:
