Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude replies from list timelines #8683

Merged
merged 2 commits into from
Sep 27, 2018
Merged

Conversation

cbayerlein
Copy link
Contributor

A small tweak in list behaviour: Now all posts that are replies are filtered out, so that now only "genuine" posts are displayed in the list.

Of course this is a bit sub-optimal in that it would be better to have a certain subset of these replies - namely those on posts whose authors are also list members. But filtering that requires a bit more complex logic.

One would have to find the post to which the reply relates. Then seek the author of this post and then a comparison, if they are a list member.

The best way would be to provide the user with a setting which gives them an option to choose whether the want the "old" or "new" behavior.

This is a first approach to solve issue #5916

I added the following line to the FeedManager (app/lib/feed_manager.rb) in the push_to_list function:

`return false if status.reply?`

Now all posts that are replies are filtered out, so that now only "genuine" posts are displayed in the list.

This is a first approach to solve issue mastodon#5916
@Gargron Gargron changed the title Changed list behaviour Exclude replies from list timelines Sep 27, 2018
app/lib/feed_manager.rb Outdated Show resolved Hide resolved
@Gargron Gargron merged commit 4b78546 into mastodon:master Sep 27, 2018
ht164 added a commit to ht164/mastodon that referenced this pull request Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants