Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not push DMs into the home feed #8940

Merged
merged 2 commits into from
Oct 10, 2018
Merged

Do not push DMs into the home feed #8940

merged 2 commits into from
Oct 10, 2018

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Oct 9, 2018

This is a UX-oriented change. With conversations API, DMs now feel a lot more like DMs. Having them in the home timeline has always been a little strange and unnecessary.

Furthermore, we need to improve support for restricted-audience posts, i.e. private posts where not all followers are allowed to see it, but only an explicit list of recipients. From protocol view, that looks the same as a DM, but from the UX view, those are the posts that would need to be in the home feed. So this PR is a clean up in preparation for that.

@trwnh
Copy link
Member

trwnh commented Oct 9, 2018

I'm not sure this makes 100% sense, because aren't those direct posts still technically replies to something? I like having my home feed show the people I'm following, including their direct posts to me. It might be fine if they were filtered out only when the DM column is pinned, like with the notification column. And of course, it'd be best as an option.

@nightpool
Copy link
Member

like with the notification column

Are you saying that if I unpin the notifications column, notifications will show up in my home feed? Is this true?

@trwnh
Copy link
Member

trwnh commented Oct 9, 2018

@nightpool No, I meant that DMs are made to not show in the notification column when the DM column is pinned. Sorry for any confusion

@shleeable
Copy link
Contributor

This is excellent... I keep having the fear that I'm going to accidentally reply to a public toot thinking it's a DM. ;)

@Gargron Gargron merged commit 87fdd13 into master Oct 10, 2018
@Gargron Gargron deleted the fix-remove-dms-from-home branch October 10, 2018 23:31
@@ -11,6 +13,7 @@ const initialState = ImmutableMap({
items: ImmutableList(),
isLoading: false,
hasMore: true,
mounted: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is slightly confusing as mounted is used as a number below.

render_anonymous_payload(status)

if status.direct_visibility?
deliver_to_mentioned_followers(status)
deliver_to_direct_timelines(status)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means the old API won't be able to access newer direct toots. I thought we could have some transition period before dropping that?

Gargron added a commit that referenced this pull request Aug 31, 2020
And remove highlighting in web UI

Full circle from #8940
Gargron added a commit that referenced this pull request Sep 1, 2020
thenameisnigel-old pushed a commit to ChatterlyOSE/Chatterly that referenced this pull request Sep 6, 2020
thenameisnigel-old pushed a commit to ChatterlyOSE/Chatterly that referenced this pull request Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants