Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove character counter from edit profile #9100

Merged
merged 3 commits into from
Oct 25, 2018

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Oct 25, 2018

HTML in translation is bad enough given that many translators on Weblate cannot code, but here it's also pluralized, creating issues like #9088. Instead, why not simply limit the input with maxlength? It's less upfront, but I also think that editing display name / bio comes up less often.

@Gargron Gargron added the ui Front-end, design label Oct 25, 2018
@Gargron Gargron merged commit 161aead into master Oct 25, 2018
@Gargron Gargron deleted the fix-remove-profile-counter-hint branch October 25, 2018 23:55
@nightpool
Copy link
Member

hmm. I think this was a bad idea. we need to fix plurals on weblate, and now we have a check for them. there's no reason to think that avoiding plurals alltogether will help

@barzamin
Copy link
Contributor

strongly support @nightpool fwiw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Front-end, design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants