Redesign admin accounts index #9340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Gargron
commented
Nov 24, 2018
•
Gargron
commented
- Make clear which accounts are deleted/suspended
- Make clear which accounts are bots/staff (via badges)
- Show when local account was last active and which IP it used
- Strip whitespace before filtering
- Default to not showing remote accounts
- Default to not showing suspended accounts
- Remove alphabetic ordering
- Fix Moderation accounts list is out of sync with the admin dashboard #9246
- Fix Additional filter "active accounts" for account moderation GUI #8190
- See also Inundated with spambots #8122
Gargron
force-pushed
the
fix-admin-accounts-index
branch
2 times, most recently
from
f393a04
to
929b4d1
Compare
- Display suspended status, role, last activity and IP prominently - Default to showing local accounts - Default to not showing suspended accounts
Gargron
force-pushed
the
fix-admin-accounts-index
branch
from
929b4d1
to
67d467d
Compare
Gargron
force-pushed
the
fix-admin-accounts-index
branch
from
262f7c9
to
5893bee
Compare
|
“Permissions” → “Roles”? “Permissions” kind of makes sense for Admin/Moderator/User, but not for bot |
|
Yeah I can see the sense in that but would prefer not to update all the locales just for this. |
| @@ -63,7 +63,7 @@ function main() { | |||
| content.textContent = timeAgoString({ | |||
| formatMessage: ({ id, defaultMessage }, values) => (new IntlMessageFormat(messages[id] || defaultMessage, locale)).format(values), | |||
| formatDate: (date, options) => (new Intl.DateTimeFormat(locale, options)).format(date), | |||
| }, datetime, now, datetime.getFullYear()); | |||
| }, datetime, now, now.getFullYear()); | |||
There was a problem hiding this comment.
This is an unrelated fix. Public pages were displaying "Nov 28" even for dates 2 years back, unlike the web UI, which correctly displayed "Nov 28, 2016", because of this mistake
ykzts
approved these changes
Nov 26, 2018
so the new default ordering is by "most recent" is that right? |
|
Yes. I have not found any practical uses for alphabetic sorting. |
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
* Improve overview of accounts in admin UI - Display suspended status, role, last activity and IP prominently - Default to showing local accounts - Default to not showing suspended accounts * Remove unused strings * Fix tests * Allow filtering accounts by IP mask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.