Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test flakiness #1351

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix test flakiness #1351

wants to merge 2 commits into from

Conversation

MichaelChirico
Copy link

@MichaelChirico MichaelChirico commented Oct 2, 2023 •
edited
Loading

Closes #1350

Alternatively, we can use a set.seed(), but keeping this test random does make it slightly more interesting.

I also tried with n=150, it fails ~0.05% of the time. I didn't notice a speed difference on n=150/n=200, so I stuck with the safer n=200.

@MichaelChirico
Copy link
Author

Another option is to deterministically ensure 1:15 are present, e.g. instead of sample.int(15, 100, TRUE), we do c(1:15, sample.int(15, 85, TRUE)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test on dummyVars
1 participant
@MichaelChirico