Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip if no .git root folder found #81

Merged
merged 2 commits into from
Oct 17, 2022
Merged

fix: skip if no .git root folder found #81

merged 2 commits into from
Oct 17, 2022

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Sep 27, 2022

close #80

@toplenboren
Copy link
Owner

looks good, merge it when ready =)

@JounQin
Copy link
Contributor Author

JounQin commented Sep 29, 2022

@toplenboren Just found I forgot to add return statement, it should be ready now?

@n0th1ng-else
Copy link

I just faced the same issue. looking forward to have the fix released 🙏🏿

@toplenboren toplenboren merged commit 499a998 into toplenboren:master Oct 17, 2022
@toplenboren
Copy link
Owner

Hi, just published https://www.npmjs.com/package/simple-git-hooks/v/2.8.1 with this fix

@JounQin @n0th1ng-else

@JounQin thanks for this fix :-)

@cuebit
Copy link

cuebit commented Oct 17, 2022

Will there be a release tag created for this?

@JounQin JounQin deleted the fix/no_git branch October 18, 2022 02:10
@sfe-efficy sfe-efficy mentioned this pull request Jan 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toplenboren toplenboren toplenboren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It should skip installation if no .git folder found
4 participants
@JounQin @toplenboren @n0th1ng-else @cuebit