Fix incorrect pagination in journaling #848
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs:
Chewy::Stash::Journal.entries
methods as any es query have a limit of default 10 and in case you have more than 100 they are going to be ignored. Instead, pagination is based on thetotal_count
will scan through all entires in the journal.created_at
, but in reality, it's not.As an example imagine the following entries in the journal
and the current algorithm step by step
12:00:00
, as a result, entries with ids 1, 3 will be fetched (src)12:04:00
12:04:00
, as a result, we are going have entry withid: 4
onlyThis bug fix is simple, fetch all entries ordered by
created_at
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).