Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't duplicate matrix in github actions file #153

Closed
fabienheureux opened this issue Feb 9, 2022 · 1 comment
Closed

Don't duplicate matrix in github actions file #153

fabienheureux opened this issue Feb 9, 2022 · 1 comment

Comments

@fabienheureux
Copy link
Contributor

fabienheureux commented Feb 9, 2022

Following this comment #152 (comment)

I would like to suggest using a more synthetic approach to the way the matrix is written in https://github.com/torchbox/wagtail-wordpress-import/blob/main/.github/workflows/test.yml#L17-L20

We can easily use a json file in order to specify the versions, based on this example : https://github.com/nobe4/test-action-matrix
Let me know what you think of this approach, I would be happy to implement it 👍

@fabienheureux fabienheureux mentioned this issue Feb 14, 2022
3 tasks
@nickmoreton
Copy link
Collaborator

Closing as this was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants