Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable git pull unless doing a publish #187

Closed
kpgalligan opened this issue Dec 22, 2022 · 1 comment
Closed

Disable git pull unless doing a publish #187

kpgalligan opened this issue Dec 22, 2022 · 1 comment
Assignees

Comments

@kpgalligan
Copy link
Collaborator

kpgalligan commented Dec 22, 2022

We run git pull --tags in gradle evaluate because we need version for publishing, but that's not great to do automatically. We should disable all of that unless we pass in some kind of CLI param, to avoid local dev doing weird things.

This is doing unnecessary work in the case where someone is just developing locally. In reality, the operations are likely only needed in CI or if someone is intentionally running kmmbridge tasks locally. We could require a gradle property to be passed in order for anything publish related (the tag pull)to happen during configuration. We should quit early if we don't see this new property

@samhill303
Copy link
Contributor

No longer relevant with latest versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants