Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

grpc-interop tests run on CI #3

Closed
hawkw opened this issue Dec 13, 2017 · 9 comments
Closed

grpc-interop tests run on CI #3

hawkw opened this issue Dec 13, 2017 · 9 comments
Assignees
Labels

Comments

@hawkw
Copy link
Member

hawkw commented Dec 13, 2017

We should put together a set of tests running the gRPC interoperability test cases and run them automatically on CI builds.

@carllerche
Copy link
Member

Yes!

And generally have tests :)

@hawkw
Copy link
Member Author

hawkw commented Dec 13, 2017

@carllerche that, too! :)

I was going to assign this issue to myself, but turns out I'm only a collaborator on the tower-rs/tower repo.

@hawkw
Copy link
Member Author

hawkw commented Dec 29, 2017

Apparent hang with the gRPC-interop large_unary test, possible flow control issue?

@carllerche
Copy link
Member

Is it possible to get a subset of the interop tests merged in initially? Just having something running in CI would be a big win.

@hawkw
Copy link
Member Author

hawkw commented Jan 2, 2018

@carllerche sure, I was thinking about that myself, especially since a number of them depend on TLS and are going to be unimplemented for a while yet. I'll see about getting the current sent to a point where I can open a PR for them.

@hawkw hawkw added the testing label Jan 9, 2018
@hawkw
Copy link
Member Author

hawkw commented Jan 10, 2018

As of 4d626af:

Current state of test implementation:

We have a test client implementation with a framework for adding more tests. We have not yet implemented a test server, and the docker-compose file for running the tests currently runs them against grpc-go's test server for now.

Test checklist

  • empty_unary: implemented in client
  • cacheable_unary: started, requires request context implementation to set cacheable flag
  • large_unary: implemented in client, broken due to Hang with grpc-interop "large_unary" test #14
  • client_compressed_unary: requires gRPC compression, NYI
  • server_compressed_unary: requires gRPC compression, NYI
  • client_streaming: implemented in client, broken due to client does not properly send streaming requests #16
  • client_compressed_streaming: requires gRPC compression, NYI
  • server_streaming
  • server_compressed_streaming: requires gRPC compression, NYI
  • ping_pong
  • empty_stream
  • compute_engine_creds requires auth, NYI
  • jwt_token_creds requires auth, NYI
  • oauth2_auth_token requires auth, NYI
  • per_rpc_creds requires auth, NYI
  • custom_metadata
  • status_code_and_message
  • unimplemented_method
  • unimplemented_service
  • cancel_after_begin
  • cancel_after_first_response
  • timeout_on_sleeping_server
  • concurrent_large_unary: not yet added to test case descriptions

@hawkw
Copy link
Member Author

hawkw commented Jan 10, 2018

Considering closing this issue as a subset of the interop tests do now run on CI, and creating new issue(s) to track the implementation of additional test cases.

@carllerche
Copy link
Member

That's fine, feel free to do so.

@hawkw
Copy link
Member Author

hawkw commented Jan 10, 2018

In that case, this was closed by #19.

@hawkw hawkw closed this as completed Jan 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants