buildACLConfigRoutersAndServices in pkg/provider/provider.go does not return an error

[dtomcej]

Feature Request

Proposal

upcoming buildACLConfigRoutersAndServices in pkg/provider/provider.go should return an error. The non-ACL version returns an error if it is unable to build config pieces.

Background

Consistent behaviour makes debugging easier.

[jspdown]

The only reason why buildConfigRoutersAndServices returns an error is because it's checking if the traffic-type is something valid. buildACLConfigRoutersAndServices is checking that too but we can't interrupt the traffic-target loop on the first error we encounter. We still want to evaluate the configuration in a best effort fashion.

As a quick fix, I suggest we check the traffic-type and scheme once and for all as a first step when we process a service.
In the long run I would love to see this code being restructured. Right now it's just a bunch of functions which call other functions (really deep) without any appearing logic. If would be pleased have a conversation with you an @kevinpollet about how we could improve this structure.