Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept truthy value for env var #27

Closed
chbndrhnns opened this issue Mar 2, 2021 · 0 comments · Fixed by #28
Closed

Accept truthy value for env var #27

chbndrhnns opened this issue Mar 2, 2021 · 0 comments · Fixed by #28

Comments

@chbndrhnns
Copy link
Contributor

chbndrhnns commented Mar 2, 2021 •
edited
Loading

The check for the value of env_var_name is currently not documented but it requires the value "true". I suggest that we accept other truthy values like True or 1, as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow truthy values for env variable chbndrhnns/prometheus-fastapi-instrumentator
1 participant
@chbndrhnns