Inheritance in metric_namespace and metric_subsystem

[bjb19]

When I set the value of metric_namespace and metric_subsystem at the instrument level it seems like this should propagate down to the metrics (Similar to the default). This does not seem to be the case when working with examples. Happy to open a PR.

[trallnag]

Hi, what "examples" do you mean? Can you give an example?

Also feel free to open PR. But note that I have low interest / low priority in this project. So it will be a few weeks until I get around to review, merge, and so on.

[glebignatieff]

He means that if you set up your own metrics, then assigning metric_namespace and metric_subsystem in the instrument() method has no effect. As a result, you have to specify them per metric like this:

instrumentator.add(metrics.requests(metric_namespace=METRICS_NAMESPACE))
instrumentator.add(metrics.latency(metric_namespace=METRICS_NAMESPACE))

[bjb19]

Yeah that is a correct example. Thanks for the notice. This is not a pressing issue for me as there is an easy workaround but I appreciate your time!