Skip to content
This repository has been archived by the owner on Aug 6, 2018. It is now read-only.

SECURITY: Vulnerability in transient dependency #70

Closed
manuelkiessling opened this issue Mar 7, 2018 · 6 comments
Closed

SECURITY: Vulnerability in transient dependency #70

manuelkiessling opened this issue Mar 7, 2018 · 6 comments

Comments

@manuelkiessling
Copy link

Here is the output of NSP:

yarn run nsp check
yarn run v1.3.2
$ /.bin/nsp check
(+) 1 vulnerability found
┌────────────┬────────────────────────────────────────────────────────────────────┐
│            │ Prototype pollution attack                                         │
├────────────┼────────────────────────────────────────────────────────────────────┤
│ Name       │ hoek                                                               │
├────────────┼────────────────────────────────────────────────────────────────────┤
│ CVSS       │ 4 (Medium)                                                         │
├────────────┼────────────────────────────────────────────────────────────────────┤
│ Installed  │ 2.16.3                                                             │
├────────────┼────────────────────────────────────────────────────────────────────┤
│ Vulnerable │ <= 4.2.0 || >= 5.0.0 < 5.0.3                                       │
├────────────┼────────────────────────────────────────────────────────────────────┤
│ Patched    │ > 4.2.0 < 5.0.0 || >= 5.0.3                                        │
├────────────┼────────────────────────────────────────────────────────────────────┤
│ Path       │ redacted > uppy-server@0.11.1 >                  │
│            │ grant-express@3.8.0 > grant@3.8.0 > request@2.81.0 > hawk@3.1.3 >  │
│            │ hoek@2.16.3                                                        │
├────────────┼────────────────────────────────────────────────────────────────────┤
│ More Info  │ https://nodesecurity.io/advisories/566                             │
└────────────┴────────────────────────────────────────────────────────────────────┘

Also see simov/grant/issues/86 for the issue in the project which can actually fix the problem.

@ifedapoolarewaju
Copy link
Contributor

@manuelkiessling thank you for reporting this. I'll look into it.

@simov
Copy link

simov commented Mar 14, 2018

👋 I've resolved the security issue in Grant v4, so all you need to do is bump the version here. Also check out the changelog. Migration should be pretty straightforward.

Let me know if you have any issues!

@ifedapoolarewaju
Copy link
Contributor

@simov I did run into an issue after upgrading to Grant 4. See here

@simov
Copy link

simov commented Mar 15, 2018

Fixed in version 4.0.1 🎉

@ifedapoolarewaju
Copy link
Contributor

upgraded, thanks for all the input in this 😉

@manuelkiessling
Copy link
Author

@ifedapoolarewaju and @simov, thank you so much for doing such an awesome job for all of us, highly appreciated!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants