Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about not wrapping in form #51

Closed
mifi opened this issue Jan 7, 2023 · 7 comments
Closed

Add note about not wrapping in form #51

mifi opened this issue Jan 7, 2023 · 7 comments

Comments

@mifi
Copy link
Contributor

mifi commented Jan 7, 2023

Something like:

Warning: Be careful not to wrap your Uppy root HTML element in a <form>, and make sure there is no form lower in the HTML tree. If there is a <form> element anywhere below Uppy's root element, it will capture submit events from plugins like Unsplash and URL (and possibly others).

Not sure where to write this though, any thoughts?

(This mistake broke for submit on all demos on transloadit.com)

@Murderlon
Copy link
Member

Good one. I think it should be in all UI plugin's under the target option and in the "Creating your own UI" guide.

@mifi
Copy link
Contributor Author

mifi commented Jan 8, 2023

Alternatively we could explore the possibility of having a <form> internally inside the Uppy plugins, what do you think?

@Murderlon
Copy link
Member

I think part of you comment is missing 😅 (having a ....).

@mifi
Copy link
Contributor Author

mifi commented Jan 9, 2023

Oops! Markdown took my <form> a bit too literaly 😄

@Murderlon
Copy link
Member

So you mean a form inside Uppy? Could be worth exploring yeah

@mifi
Copy link
Contributor Author

mifi commented Jan 9, 2023

yes, we had a thread about it on slack. @arturi is exploring whether we can handle form submits from inside upp without having a form at all.

@aduh95
Copy link
Contributor

aduh95 commented Jan 22, 2023

I think we can close this in favor of not putting any <form> element in the Uppy DOM tree, as discussed in the Uppy call :)

@aduh95 aduh95 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants