Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XHRUpload seems to be not working when using Companion server #1390

Closed
MiloszKrajewski opened this issue Mar 28, 2019 · 9 comments
Closed

XHRUpload seems to be not working when using Companion server #1390

MiloszKrajewski opened this issue Mar 28, 2019 · 9 comments
Labels

Comments

@MiloszKrajewski
Copy link

Using uppy companion server and client using Tus for upload works fine.

Unfortunately I need to use XHRUpload in one case, and this seems to be not working at all.
When uploading file from "my device" everything work great (so XHR upload is configured properly) but when trying to upload from "Link" after pressing Upload button nothing happens: progress indication is spinning forever and no network activity (debug tools) is observed.

Am I doing it wrong? Or it is just not supported?

Thanks,
Milosz

@arturi
Copy link
Contributor

arturi commented Mar 29, 2019

Confirmed the bug, we are looking into it, thanks for reporting!

@arturi arturi removed the Triage label Mar 29, 2019
@arturi
Copy link
Contributor

arturi commented Mar 29, 2019

The bug has been fixed by:
de04c79 and c1abfea

@KhalilMohammad
Copy link

Are npm packages updated?

@arturi
Copy link
Contributor

arturi commented Apr 1, 2019

@KhalilMohammad Not yet, a release likely coming this week.

@goto-bus-stop
Copy link
Contributor

Looks like this was released in 1.0.0. Thanks!

@gabbanaesteban
Copy link

I'm using 1.0.2 and the issue still happening again.

@MiloszKrajewski
Copy link
Author

MiloszKrajewski commented May 17, 2019

In my case: 1.0.0 frontend -> 1.0.0 uppy works fine but 1.0.0 -> 1.0.1 does not. 1.0.1 -> 1.0.1 works again.
I did not try 1.0.2 but my suggestion would be to test if you have matching frontend/backend versions.
NOTE: I'm talking about GoogleDrive/Dropbox/Instagram as I'm not using Link anymore.

@gabbanaesteban
Copy link

I tried 1.0.0 but couldn't connect to Google Drive using that version.

@arturi
Copy link
Contributor

arturi commented May 18, 2019

@gabbanaesteban, @MiloszKrajewski

In my case: 1.0.0 frontend -> 1.0.0 uppy works fine but 1.0.0 -> 1.0.1 does not.

If you are experiencing issues with authentication with Google Drive or Instagram, it is due to a breakage of backwards-compatibility we’ve accidentally introduced in @uppy/companion@1.0.1.

The fix was released yesterday on npm as @uppy/companion@1.0.2, see #1564 for details.

Please update @uppy/companion to v1.0.2 for backwards-compatibility with Uppy Client ^1.0.0, @uppy/companion@1.0.1 is now deprecated.

Sorry about the trouble! Please do let us know if the issue is resolved for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants