Add Done button when upload is successfully finished

[jazkh]

Uppy 1.0.0
Browser: Chrome
Windows 10

Close button is not displaying properly in Dasboardmodal and shows out of the dashboard window.
Also, there is no Done button when upload is successfully finished.

[goto-bus-stop]

The × is actually at the intended position there 😅

As for a "done" button, you do indeed need to close the modal using the × after everything is finished… @nqst (don't answer today!), do you think an additional "Done" button in the bottom right of a "Completed" status bar could make sense?

[nqst]

@jazkh, yeah it's intended to have the [×] button outside the window. We want it to be placed outside, because some parts of UI are placed in the upper right corner, like on the screenshot below. Placing the close button there will cause a conflict.

@goto-bus-stop, I like the idea of having a [Done] button there (and in the inline mode too)! Might be useful when users want to upload even more files after the upload has finished. Adding this button will also provide an ability to easily return to the initial state, which is a must-have. Would also like to invite @arturi to discuss this.

[arturi]

I like the [Done] button idea, but wonder how it would work with StatusBar outside the Dashboard. It can be added as an option for StatusBar showDoneButton, set true when used with the Dashboard. What would the button do in the code, call uppy.reset()? That won’t close the Dashboard modal 🤔

[arturi]

Done button was requested earlier as well: #875

[arturi]

DevinCarpenter:

I think it would be a good idea to add in the option of some sort of custom button that pops up on the Uppy Dashboard after adding images/files, and maybe an onclick option for it.

In my case I needed a 'Done' button as I was using a custom button for uploading and didn't need the upload button on the dashboard, but still wanted something to pop up. I've already hacked it to work so the button closes the dashboard so this is just a suggestion.

Big thanks Uppy team you guys are rockin it.

[kvz]

Hi there, we like this idea and we've moved this to our backlog. We don't have an ETA for this yet though, and if someone in the community feels like contributing a PR we would be very grateful! Closing this issue here now but we'll re-open when we get to it.