Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meeting Google's Branding Compliance Requirement #3153

Closed
mazoruss opened this issue Aug 31, 2021 · 11 comments · Fixed by #3178 or #4345
Closed

Meeting Google's Branding Compliance Requirement #3153

mazoruss opened this issue Aug 31, 2021 · 11 comments · Fixed by #3178 or #4345
Labels

Comments

@mazoruss
Copy link
Contributor

mazoruss commented Aug 31, 2021

Hi Uppy team,

First of all, thank you for the Uppy library, it has helped us implement our uploader with ease.
We currently let users upload from local disk, box, dropbox, and google drive, The first three works just fine, but Google has given us some issues. We requested to have our app verified by Google, and they responded with the following email.

`Hi,

Unfortunately, since the button initiates the OAuth Sign-in process, it is required to comply with the Google sign-in branding guidelines. Please update any links and/or buttons on your application that initiate the OAuth Sign-in process to comply with our policies.

Once you have made the appropriate updates to your site and/or your OAuth Consent Screen, please reply directly to this email so that we may continue with the verification process.
Please see attached screenshot for reference.

Note: Failure to satisfy/provide the preceding information might result in a rejection of your request. To avoid this outcome, update the applicable information in your request to meet our requirements.

If you have any other questions, you can read the OAuth Application Verification FAQ or reply directly to this email.

Thanks,
The Google Cloud Trust & Safety Team`

Here's the attachments they sent:

updategooglebutton

And the link they gave:

https://google.com/url?&q=http%3A%2F%2Fdevelopers.google.com%2Fidentity%2Fbranding-guidelines%23top_of_page

And I suspect this section as well even though it was not in the screenshot they sent:

Screen Shot 2021-08-31 at 1 46 52 PM

After reading their guidelines, my understanding is that these need to use their "G" icon in order to meet the requirement, and I don't think Uppy currently supports customization to these icons. Although I can probably do something hacky on my end to change these icons, I think it's best for the sake of other developers if you guys can modify the icons to meet Google's (overly strict?) guidelines.

P.S.(rant) I also don't see how the Google Drive triangle icon ISN'T part of their brand.

@ercanzirh
Copy link

Yes, we're also facing this issue. And it's very frustrating. Any solution or suggestion?

Uppy-GoogleDrive

@Murderlon
Copy link
Member

I'll check with our designer and come back to this.

@ercanzirh
Copy link

I'll check with our designer and come back to this.

any luck?

@Murderlon
Copy link
Member

Created a PR

@mojowill
Copy link
Contributor

mojowill commented Mar 2, 2023

Adding to this that despite the changes we are still facing issues related to Google Drive brand guidelines. I think the issue is that the white drive icon is not official and in breach of their brand guidelines.

Is there a way to provide alternate icons that do meet Google Drives brand guidelines?

@Murderlon
Copy link
Member

Hi, I see the updated the guidelines. Before there were multiple options, also monochrome. Now this is the only allowed option. Which is quite annoying because it doesn't match with our other icons at the moment. Nonetheless we will do something about it.

image

@mojowill
Copy link
Contributor

mojowill commented Mar 2, 2023

I've gone back to them as well as they provided two screenshots to ensure the Sign in with Google isn't also breaching their guidelines.

Screenshot 2023-03-02 8 58 36 AM
Screenshot 2023-03-02 8 58 50 AM

@mifi mifi reopened this Mar 4, 2023
@mojowill
Copy link
Contributor

mojowill commented Mar 6, 2023

Is there any potential timescale on making this change? We're completely blocked by this at the moment.

@Murderlon
Copy link
Member

There is a branch but not yet a PR. We'll try to wrap it up today. Preview:

image

@mojowill
Copy link
Contributor

mojowill commented Mar 7, 2023

I see this is now merged which is great, when will it show up in a release we can use?

@Murderlon
Copy link
Member

Released :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants