Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"The folder X was already added" #4381

Closed
2 tasks done
mifi opened this issue Mar 28, 2023 · 0 comments · Fixed by #4384
Closed
2 tasks done

"The folder X was already added" #4381

mifi opened this issue Mar 28, 2023 · 0 comments · Fixed by #4384
Labels
Bug

Comments

@mifi
Copy link
Contributor

mifi commented Mar 28, 2023 •
edited
Loading

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

  • Create a folder structure in a provider like so:
    • folder1 > folder2 > folder3 >somefile.jpeg
  • select folder1

Expected behavior

It should add somefile.jpeg without any errors

Actual behavior

it shows 3 toasts "The folder folderX was already added", before adding the file

seems to be this code that's buggy:

uppy/packages/@uppy/provider-views/src/ProviderView/ProviderView.jsx

Line 217 in 376375c

if (count === 0) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

@uppy/provider-views: fix race condition when adding folders transloadit/uppy
1 participant
@mifi