Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS example doesn't demonstrate how to do signing on the client #4510

Closed
2 tasks done
aduh95 opened this issue Jun 19, 2023 · 1 comment · Fixed by #4463
Closed
2 tasks done

AWS example doesn't demonstrate how to do signing on the client #4510

aduh95 opened this issue Jun 19, 2023 · 1 comment · Fixed by #4463
Labels

Comments

@aduh95
Copy link
Contributor

aduh95 commented Jun 19, 2023

Initial checklist

  • I understand this is a feature request and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Problem

The example only shows how to make signing on the server. Using AWS STS, it's possible to do signing on the client.

Solution

Add an example with signing on the client which uses WebCrypto and a STS session token.

Alternatives

Here are the alternatives I've thought for the actual signing:

  • Add the signing algorithm to @uppy/utils, and add a dependency to @uppy/utils in the example package.
  • Add the signing algorithm to @uppy/aws-s3-mutlipart.
  • Add the signing algorithm as plain JS in the example (not great for readability)
  • Add a dependency to the AWS SDK (but the example goal seems to be to show off the integration without any external dependency on the client)
@Murderlon
Copy link
Member

How would it look for @uppy/aws-s3-multipart? Just an option like signOnClient: boolean?

@arturi arturi removed the Triage label Jul 6, 2023
@aduh95 aduh95 linked a pull request Jul 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants