Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resuming S3 Multipart Upload Does Not Check shouldUseMultipart #4527

Closed
2 tasks done
DiyarAniwar-at opened this issue Jun 23, 2023 · 0 comments · Fixed by #4528
Closed
2 tasks done

Resuming S3 Multipart Upload Does Not Check shouldUseMultipart #4527

DiyarAniwar-at opened this issue Jun 23, 2023 · 0 comments · Fixed by #4528
Labels
Bug

Comments

@DiyarAniwar-at
Copy link

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

  • Start an Upload with a file that would only need 1 part
  • Pause Upload
  • Resume Upload
  • Observe that nonMultipartUpload is used despite shouldUseMultipart defaulting to false.

Expected behavior

Should check !chunks[0].shouldUseMultipart before deciding to use nonMultipartUpload.

https://github.com/transloadit/uppy/blob/main/packages/%40uppy/aws-s3-multipart/src/index.js#L258-L260

Actual behavior

nonMultipartUpload is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

@uppy/aws-s3-multipart: fix resume single-chunk multipart uploads aduh95/uppy
1 participant
@DiyarAniwar-at