DashboardMiscOptions.trigger
requires string
, but findAllDOMElements
accepts Node
as well
#5099
Closed
2 tasks done
Labels
Initial checklist
Link to runnable example
No response
Steps to reproduce
This is less of a bug and more of a correct typing-issue.
The
trigger
field onDashboardMiscOptions
requiresstring
:uppy/packages/@uppy/dashboard/src/Dashboard.tsx
Line 169 in c45407d
But processing calls
findAlDOMElements(this.opts.trigger)
:uppy/packages/@uppy/dashboard/src/Dashboard.tsx
Line 987 in c45407d
Which allows DOM Elements as well:
uppy/packages/@uppy/utils/src/findAllDOMElements.ts
Lines 13 to 24 in c45407d
Expected behavior
That the
trigger
field mirrors the accepted types offindAllDOMElements()
.Actual behavior
The
trigger
field requires an optionalstring
.The text was updated successfully, but these errors were encountered: