From e57cf05a79e3ec48c2d2fca84f3a6d661fefa8a0 Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Mon, 3 Jun 2024 18:18:58 +0200 Subject: [PATCH 1/3] remove prepublishOnly it doesn't work with yarn berry see discussion in #4682 --- packages/@uppy/companion/package.json | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/@uppy/companion/package.json b/packages/@uppy/companion/package.json index 2fa233382b..20bdebf1b6 100644 --- a/packages/@uppy/companion/package.json +++ b/packages/@uppy/companion/package.json @@ -107,7 +107,6 @@ "scripts": { "build": "tsc -p .", "deploy": "kubectl apply -f infra/kube/companion-kube.yml", - "prepublishOnly": "yarn run build", "start": "node ./lib/standalone/start-server.js", "test": "jest" }, From cb96c0e50f76f6e0df45dcab5827b9ede20b72e0 Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Mon, 3 Jun 2024 18:20:32 +0200 Subject: [PATCH 2/3] Update CONTRIBUTING.md --- .github/CONTRIBUTING.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 0491480070..0a2127beea 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -285,6 +285,11 @@ Now let’s create the version & tag: mkdir -p .git && npm version --workspaces-update=false --tag-version-prefix='@uppy/companion@' patch ``` +**Important:** Build Companion lib folder +```bash +yarn run build +``` + Run a “dry-run” first: ```bash From e28d43b936d99884772c927d33380fb4adc1f4ca Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Mon, 3 Jun 2024 18:53:33 +0200 Subject: [PATCH 3/3] fix prettier --- .github/CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 0a2127beea..2c4ab1781e 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -286,6 +286,7 @@ mkdir -p .git && npm version --workspaces-update=false --tag-version-prefix='@up ``` **Important:** Build Companion lib folder + ```bash yarn run build ```