Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Incorporate faker.js project / data #4

Open
Marak opened this issue Sep 24, 2014 · 1 comment
Open

Suggestion: Incorporate faker.js project / data #4

Marak opened this issue Sep 24, 2014 · 1 comment

Comments

@Marak
Copy link

Marak commented Sep 24, 2014

Hello there.

I wanted to make a friendly suggestion that you might want to incorporate data from or merge parts of this project with https://github.com/marak/faker.js

The functionalities seem very overlapping and we've got many active contributors and javascript localization datasets for 27 localities.

I'd be willing to add you as a contributor or even transfer the faker.js project to a new organization. The specific functionalities you've added to fake-identity would be useful to have in faker.js.

A better goal would probably be to separate out faker.js localization data to separate modules so libraries like fake-identity and faker.js could easily consume the same data sets.

@travishorn
Copy link
Owner

I have seen faker.js but I haven't taken a dive into the code, yet. I'll take a look at it. Thanks for the heads up. If you'd like to add me as a contributor, that would be OK. I'll try to set some time aside to incorporating some of the fake-identity code to faker.

I'll bet having modular data sets would also be useful for other developers that need access to the data alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants