Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Add licenses checking to the test phase of the build pipeline #349

Open
stefanotorresi opened this issue Oct 19, 2021 · 3 comments · May be fixed by #741
Open

Add licenses checking to the test phase of the build pipeline #349

stefanotorresi opened this issue Oct 19, 2021 · 3 comments · May be fixed by #741
Assignees
Labels
DX Developer Experience enhancement Improvement of existing features

Comments

@stefanotorresi
Copy link
Member

Check this out: https://github.com/google/go-licenses

@stefanotorresi stefanotorresi added enhancement Improvement of existing features DX Developer Experience labels Oct 19, 2021
@dottorblaster
Copy link
Contributor

@flaviodsr flaviodsr self-assigned this Jan 26, 2022
@flaviodsr flaviodsr linked a pull request Jan 26, 2022 that will close this issue
@flaviodsr
Copy link
Contributor

I have tried to use google/go-licenses with no success, even the examples from the README fail to run, there are also multiple issues (including the broken examples) open. Seems like there is an effort to fix many of the issues on version 2 which is under development.

frapposelli/wwhrd works, however it requires a configuration file where you need to specify the allowed licenses, while go-licenses uses google/licenseclassifier to automatically classify the license. Besides that, wwhrd only checks packages stored under vendor/, so when using Go modules (go mod), you need to run go mod vendor before running wwhrd.

While the check is being implemented using wwhrd it might be worth keeping an eye for the next version of google/go-licenses for a solution where we do not need to maintain a list of allowed licenses.

@Bobgy
Copy link

Bobgy commented Apr 11, 2022

Hey @flaviodsr! JFYI, go-licenses v2 efforts have been released as v1.1.0 with doc updated. Welcome having a try : )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DX Developer Experience enhancement Improvement of existing features
Development

Successfully merging a pull request may close this issue.

4 participants