Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading median LHR of http://localhost:3000/...failed! #144

Closed
slorber opened this issue Sep 27, 2024 · 3 comments
Closed

Uploading median LHR of http://localhost:3000/...failed! #144

slorber opened this issue Sep 27, 2024 · 3 comments

Comments

@slorber
Copy link

slorber commented Sep 27, 2024

Hi

For unknown reasons, our Docusaurus Lighthouse CI workflow started to fail (using latest commit from this repository, )

https://github.com/facebook/docusaurus/actions/runs/11056655609/job/30718686539?pr=10522

I tried to troubleshoot this and the CI logs show that this action does not fail when it can't upload median LHR to Google temporary storage

      - name: Audit URLs using Lighthouse
        id: lighthouse_audit
        uses: treosh/lighthouse-ci-action@2f8dda6cf4de7d73b29853c3f29e73a01e297bd8 # 12.1.0
        with:
          urls: |
            http://localhost:3000
            http://localhost:3000/docs/installation
            http://localhost:3000/docs/category/getting-started
            http://localhost:3000/blog
            http://localhost:3000/blog/preparing-your-site-for-docusaurus-v3
            http://localhost:3000/blog/tags/release
            http://localhost:3000/blog/tags
          configPath: ./.github/workflows/lighthouserc.json
          uploadArtifacts: true
          temporaryPublicStorage: true
Uploading
  Artifact name is valid!
  Root directory input is valid!
  Beginning upload of artifact content to blob storage
  Uploaded bytes 4516766
  Finished uploading artifact content to blob storage!
  SHA256 hash of uploaded artifact zip is ed171f5ac7c2c955bfc4[60](https://github.com/facebook/docusaurus/actions/runs/11056655609/job/30718686539?pr=10522#step:6:63)c70c7c9b1c5ef2637689c89547bb4003450006bb57
  Finalizing artifact upload
  Artifact lighthouse-results.zip successfully finalized. Artifact ID 1983538537
  Uploading median LHR of http://localhost:3000/...failed!
  Uploading median LHR of http://localhost:3000/docs/installation...failed!
  Uploading median LHR of http://localhost:3000/docs/category/getting-started...failed!
  Uploading median LHR of http://localhost:3000/blog...failed!
  Uploading median LHR of http://localhost:3000/blog/preparing-your-site-for-docusaurus-v3...failed!
  Uploading median LHR of http://localhost:3000/blog/tags/release...failed!
  Uploading median LHR of http://localhost:3000/blog/tags...failed!
  No GitHub token set, skipping GitHub status check.
  Dumping 7 reports to disk at /home/runner/work/docusaurus/docusaurus/.lighthouseci...
  Done writing reports to disk.

I'm not sure exactly why it fails silently, but this leads to failure in a subsequent step because the ${{ steps.lighthouse_audit.outputs.links }} object is empty.

I believe this action should rather fail fast and stop the whole CI job in case of such an upload error with a clear error message.

I looked at the code and not sure why it's not the case honestly.


Edit:

  • my initial description was wrong, it's not uploading GitHub artifacts that failed but the temp storage on Google infrastructure.
  • although I would have appreciated a fail-fast behavior with a clear error message in such case, I also appreciate that we have the option to not fail this action in case of such failures (I guess temporaryPublicStorage : false is enough)
@slorber slorber changed the title Action doesn't fail if uploadArtifact fails Uploading median LHR of http://localhost:3000/...failed! Sep 27, 2024
@slorber
Copy link
Author

slorber commented Sep 27, 2024

Looks related to this 😅

GoogleChrome/lighthouse-ci#1072

GoogleChrome/lighthouse-ci#1073

@paulirish
Copy link
Contributor

paulirish commented Sep 30, 2024

Thanks for your action here @slorber

Good news, The storage appears to be back up now!

@slorber
Copy link
Author

slorber commented Oct 1, 2024

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants