You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
thanks for creating shinyAce, it is a great and useful package. For an application I needed listeners that can react to key presses and cursor changes. I forked your shinyAce into
and added that functionality by adding arguments cursorId and keyId, which work similar as your selectionId argument. I also changed the generated javascript code in aceEditor by naming differnent editors with the variable editorVar. This is neccessary for cursor and key events to work correctly when there are multiple aceEditors.
Here is a sample code that uses the new functioniality:
If you like the new functionality, I am very happy to merge the new version with your shinyAce version. (I have never performed a pull request, but I guess that is not so complicated).
Best wishes,
Sebastian
The text was updated successfully, but these errors were encountered:
This might actually pertain to another issue that was opened: #15
This definitely looks like useful functionality. I may end up wanting to nit pick some of the details before we merge it in, but these features could certainly be candidates for inclusion in the package. Feel free to open a PR and I'll do a more thorough review of the code to see what I'd ask for before we merge.
Hopefully I'll get to the review in a more timely manner :)
Thanks for offering the code up! Hopefully we can get it into the project so others can benefit.
Jeff
Dear Jeff,
thanks for creating shinyAce, it is a great and useful package. For an application I needed listeners that can react to key presses and cursor changes. I forked your shinyAce into
https://github.com/skranz/shinyAce
and added that functionality by adding arguments cursorId and keyId, which work similar as your selectionId argument. I also changed the generated javascript code in aceEditor by naming differnent editors with the variable editorVar. This is neccessary for cursor and key events to work correctly when there are multiple aceEditors.
Here is a sample code that uses the new functioniality:
If you like the new functionality, I am very happy to merge the new version with your shinyAce version. (I have never performed a pull request, but I guess that is not so complicated).
Best wishes,
Sebastian
The text was updated successfully, but these errors were encountered: