Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bump gas price minimum configurable, now it is 1gwei #15890

Open
Tracked by #15478
tomasklim opened this issue Dec 11, 2024 · 0 comments
Open
Tracked by #15478

Make bump gas price minimum configurable, now it is 1gwei #15890

tomasklim opened this issue Dec 11, 2024 · 0 comments
Assignees

Comments

@tomasklim
Copy link
Member

tomasklim commented Dec 11, 2024

Related to #15816

Bump fee logic should be updated here

const getEthereumFeeInfo = (info: FeeInfo, gasPrice: string) => {
    const current = new BigNumber(gasPrice);
    const minFeeFromNetwork = new BigNumber(fromWei(info.levels[0].feePerUnit, 'gwei'));

    const getFee = () => {
        if (minFeeFromNetwork.lte(current.plus(1))) {
            return current.plus(1);
        }

        return minFeeFromNetwork;
    };
...

I think we should introduce min bump amount into the config file where you modify minFee, maxFee,... and use it in this function instead of 1`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎯 To do
Development

No branches or pull requests

2 participants