Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send XRP - hardcoded reserve error messages #15894

Open
PeKne opened this issue Dec 11, 2024 · 0 comments
Open

Send XRP - hardcoded reserve error messages #15894

PeKne opened this issue Dec 11, 2024 · 0 comments
Labels
mobile Suite Lite issues and PRs
Milestone
Mobile - Send XRP

Comments

@PeKne
Copy link
Contributor

PeKne commented Dec 11, 2024 •
edited
Loading

The error messages validating if a user is failing the XRP reserve policy while sending the coins are hardcoded now. (see #15893)

It is not ideal, because the Ripple network can dynamically change the reserve and then the mobile Suite would display outdated information.

To fix this, a way to inject dynamic data into the yup validation schema error messages needs to be designed and implemented. This refactor should ideally be done together with internationalizing all the yup messages because they are currently hardcoded as English.
@PeKne PeKne added the mobile Suite Lite issues and PRs label Dec 11, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Mobile Dec 11, 2024
@PeKne PeKne mentioned this issue Dec 11, 2024
Merged
@trezor trezor deleted a comment Dec 11, 2024
@matejkriz matejkriz added this to the Mobile - Send XRP milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mobile Suite Lite issues and PRs
Projects
Suite Mobile
Status: 🎯 To do
Milestone
Mobile - Send XRP
Development

No branches or pull requests
2 participants
@matejkriz @PeKne