Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore order by in a from subquery #807

Closed
hustnn opened this issue May 23, 2019 · 6 comments
Closed

Ignore order by in a from subquery #807

hustnn opened this issue May 23, 2019 · 6 comments

Comments

@hustnn
Copy link
Member

hustnn commented May 23, 2019 •
edited
Loading

I noted some systems ignore order by in a from subquery or at least when it is not used with limit.
https://mariadb.com/kb/en/library/why-is-order-by-in-a-from-subquery-ignored/

Some more cases can benefit from it in addition to #759 mentioned by @Praveen2112

When outer query and inner query are both aggregation, it is hard to parallel outer query if we want to keep the ordering of inner query.
@kokosing
Copy link
Member

Sounds good, would like to work on this?

@hustnn
Copy link
Member Author

hustnn commented May 23, 2019

@kokosing I'd like to work on it !

@ankitdixit
Copy link
Member

@kokosing @hustnn I already have implemented a solution for other issue, which fixes this. Let me share it

@hustnn
Copy link
Member Author

hustnn commented May 23, 2019

cool. go ahead.

@ankitdixit
Copy link
Member

Thanks, this is the PR #810

@martint martint mentioned this issue May 25, 2019
Closed
@hustnn hustnn closed this as completed May 30, 2019
@hustnn
Copy link
Member Author

hustnn commented May 30, 2019

Solved in Presto 312. Quite fast !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hustnn @kokosing @ankitdixit