Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Error trait for error types #94

Closed
jmacdonald opened this issue Aug 12, 2017 · 2 comments · Fixed by #420
Closed

Implement Error trait for error types #94

jmacdonald opened this issue Aug 12, 2017 · 2 comments · Fixed by #420
Labels
enhancement

Comments

@jmacdonald
Copy link

Implementing Rust's canonical Error trait would allow errors in syntect to be chained with application-level errors, via error-chain.
@jmacdonald jmacdonald mentioned this issue Aug 31, 2017
Closed
@sharkdp sharkdp mentioned this issue Apr 30, 2018
Merged
@Enselic
Copy link
Collaborator

Enselic commented Oct 4, 2021 •
edited
Loading

For the record and FWIW: the error-chain crate has been deprecated. The new de-facto standard for libraries seems to be the thiserror crate. We recently replaced error-chain with thiserror in bat. See sharkdp/bat#1820

@Enselic
Copy link
Collaborator

Enselic commented Jan 6, 2022

I'd like to take a shot at this for 5.0.0.

@Enselic Enselic mentioned this issue Jan 6, 2022
Merged
Enselic added a commit to Enselic/syntect that referenced this issue Jan 17, 2022
@Enselic
Implement Error and Display for all error enums by using thiserror
87b02ff 
Also do some minor tweaks to the way errors are represented, and add basic
integration tests for errors, to give a feel for how the errors behave.

Fixes trishume#94
Enselic added a commit to Enselic/syntect that referenced this issue Jan 17, 2022
@Enselic
Implement Error and Display for all error enums by using thiserror
2065ae6 
Also do some minor tweaks to the way errors are represented, and add basic
integration tests for errors, to give a feel for how the errors behave.

Fixes trishume#94
@Enselic Enselic mentioned this issue Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Error and Display for all error enums by using thiserror Enselic/syntect
2 participants
@Enselic @jmacdonald