Skip to content

Latest commit

 

History

History
11 lines (10 loc) · 911 Bytes

Expectations_of_Code_Review.md

File metadata and controls

11 lines (10 loc) · 911 Bytes

Reviewer Expectations for Code Review

  • Have verified that Definition of Done has been completed
  • Visual inspection of code to see that it does what it needs to and doesn't do what is not reported
  • Confirmed that all comments and questions raised in discussion of the pull request have been resolved
  • If possible, a reviewer should build and test the code changes
  • Merging a pull request is a statement of "I believe this code is of good quality"
  • Check that consensus voting has resulted in approval of each issue resolved with the pull request (see governance document for details)
  • Check that consensus voting has resulted in approval of the pull request itself (see governance document for details)

Document Change Process

This document can be updated by following the process documented in section 6.2 of the Governance document.