[ROCM] Enable ROCM Backend #1: Empty Kernel #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add scripts functional empty kernel remove scripts clean up clean more
micmelesse
requested review from
goostavz,
Superjomn and
ptillet
as code owners
micmelesse
force-pushed
the
upstream_main_pr_1
branch
from
0871d03 to
2c5851d
Compare
This is a combination of 3 commits. Fix Issues related to CI This is a combination of 19 commits. add ci test empty kernel fix isort fix autopep8 clang fix skip lit test for rocm verbose install install rocm torch on rocm nodes remove verbose explicitly install rocm torch verbose install on rocm fix header issue uninstall torch uninteractive uninstall uninstall torchvision and torchaudio remove torch package no cache dir pin version verbose test output don't assume env var run only empty kernel test
micmelesse
force-pushed
the
upstream_main_pr_1
branch
from
0147ec6 to
5d3ba4c
Compare
micmelesse
changed the title
micmelesse
changed the title
ptillet
reviewed
Mar 18, 2023
ptillet
reviewed
Mar 18, 2023
ptillet
reviewed
Mar 18, 2023
keryell
reviewed
Mar 21, 2023
Co-authored-by: Ronan Keryell <ronan@keryell.fr>
Co-authored-by: Ronan Keryell <ronan@keryell.fr>
Co-authored-by: Ronan Keryell <ronan@keryell.fr>
Co-authored-by: Ronan Keryell <ronan@keryell.fr>
Co-authored-by: Ronan Keryell <ronan@keryell.fr>
Co-authored-by: Ronan Keryell <ronan@keryell.fr>
Co-authored-by: Ronan Keryell <ronan@keryell.fr>
Co-authored-by: Ronan Keryell <ronan@keryell.fr>
Co-authored-by: Ronan Keryell <ronan@keryell.fr>
keryell
reviewed
Mar 24, 2023
|
@micmelesse I'm going to merge this since I'm planning a refactor of the frontend over the weekend, but could you address @keryell 's remaining comment (and any pending work that you're doing) in a separate PR? thanks |
pingzhuu
pushed a commit
to siliconflow/triton
that referenced
this pull request
Apr 2, 2024
This PR is a first in a series of PRs to import the changes that we have made to enable ROCM on [our fork](https://github.com/ROCmSoftwarePlatform/triton) of triton. The PR contains the major changes to the python frontend and enough changes to the c++ backend to allow compilation and running of the empty kernel. We use the ROCM ci added a few weeks ago to verify things. --------- Co-authored-by: Ronan Keryell <ronan@keryell.fr>
pingzhuu
pushed a commit
to siliconflow/triton
that referenced
this pull request
Apr 2, 2024
…on-lang#1312 (triton-lang#1434) This PR address the remaing issues from triton-lang#1312. It does the following * LLVM String Join * adds comment to GCNBuilder Class --------- Co-authored-by: Rahul Batra <rahbatra@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first in a series of PRs to import the changes that we have made to enable ROCM on our fork of triton.
The PR contains the major changes to the python frontend and enough changes to the c++ backend to allow compilation and running of the empty kernel. We use the ROCM ci added a few weeks ago to verify things.