Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid access of op result #1500

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

frgossen
Copy link

@frgossen frgossen commented Apr 10, 2023

This triggers an assertion introduced in https://reviews.llvm.org/D147883

@Jokeren
Copy link
Contributor

Jokeren commented Apr 10, 2023

Can you rebase on top of main?

@frgossen frgossen force-pushed the main branch 3 times, most recently from 6c8e297 to 43b062d Compare April 10, 2023 20:32
@frgossen
Copy link
Author

Thanks! I will close the other PR in favor of this one.

copybara-service bot pushed a commit to openxla/xla that referenced this pull request Apr 10, 2023
This triggers an assertion introduced in https://reviews.llvm.org/D147883

See upstream PRs
triton-lang/triton#1499
triton-lang/triton#1500

PiperOrigin-RevId: 523208874
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Apr 10, 2023
This triggers an assertion introduced in https://reviews.llvm.org/D147883

See upstream PRs
triton-lang/triton#1499
triton-lang/triton#1500

PiperOrigin-RevId: 523208874
@frgossen
Copy link
Author

Is the CI building against MLIR head? mlir/Target/LLVMIR/Dialect/Builtin/BuiltinToLLVMIRTranslation.h is about 3 weeks old.

@daadaada
Copy link
Contributor

LGTM

@ptillet
Copy link
Collaborator

ptillet commented Apr 11, 2023

Let me update the LLVM wheel

@ptillet
Copy link
Collaborator

ptillet commented Apr 11, 2023

should be ok if you rebase against main

@chsigg chsigg merged commit baf2691 into triton-lang:llvm-head Apr 11, 2023
chsigg pushed a commit that referenced this pull request Apr 13, 2023
chsigg pushed a commit that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants