Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double encoding or no encoding #32

Closed
ulfryk opened this issue Mar 4, 2019 · 0 comments · Fixed by #43
Closed

Double encoding or no encoding #32

ulfryk opened this issue Mar 4, 2019 · 0 comments · Fixed by #43

Comments

@ulfryk
Copy link

ulfryk commented Mar 4, 2019

If I pass url params object containing url encoded value, it's encoded once again, else it's not encoded at all.

What I'd like to achieve is encoding (once) a param containing a path to be used elswhere. I get %252Fap%252Fexample-func-1.html%2523%252F instead of %2Fap%2Fexample-func-1.html%23%2F.

I would like to encode value once, but it seems to be impossible now.

This is cause by this line https://github.com/troch/path-parser/blob/master/modules/Path.ts#L190

If there is no way to prevent auto encoding - I'd be happy to introduce PR with update :)

I use router5 and here is an issue I filed there: router5/router5#404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant