Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow an algorithm to report back to TPL errors when running #17

Open
alastair opened this issue Mar 19, 2021 · 0 comments
Open

Allow an algorithm to report back to TPL errors when running #17

alastair opened this issue Mar 19, 2021 · 0 comments

Comments

@alastair
Copy link
Member

We should have a clear way for algorithms to report back to the TPL when they fail to run so that the TPL can set the actionStatus of the ControlAction to Failed.

I see that we are using subprocess.run and catching a blanket exception in order to set the failed status:

except:

subprocess.run can raise an exception when using check_call which I think is a good way of capturing this status.

We should be more careful about this exception handler, it's generally not a good idea to catch a blanket Exception, we should identify each potential error and handle these situations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant