Include ExtraData from customDetector http response

[CameronLonsdale]

Please review the Community Note before submitting

Description

When validating a customDetector, include the response body as part of the ExtraData

trufflehog/pkg/custom_detectors/custom_detectors.go

Line 173 in 23afcd7

// TODO: Read response body.

Preferred Solution

Read the response body and include the body as ExtraData

[kashifkhan0771]

I'm considering reading the response body based on the Content-Type header. If the content type is application/json, we can unmarshal it into a JSON structure; if it's text/plain, we can simply convert it to a string. We could also handle other common content types similarly.

@zricethezav @abmussani @ahrav any thoughts?

[ahrav]

I'm considering reading the response body based on the Content-Type header. If the content type is application/json, we can unmarshal it into a JSON structure; if it's text/plain, we can simply convert it to a string. We could also handle other common content types similarly.

@zricethezav @abmussani @ahrav any thoughts?

That seems like a good initial approach. Long term, we might consider including it in the custom detector config. However, since we're moving toward a config-based detector setup, there's no need to over-engineer this solution. Your approach is practical for now. 👍