Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git --since-commit does not notify on invalid inputs #3394

Open
JonZeolla opened this issue Oct 10, 2024 · 1 comment
Open

git --since-commit does not notify on invalid inputs #3394

JonZeolla opened this issue Oct 10, 2024 · 1 comment
Labels
bug

Comments

@JonZeolla
Copy link
Contributor

TruffleHog Version

trufflehog 3.82.7

Trace Output

https://gist.github.com/JonZeolla/bb270c47471284baa5a9572f0c473234

Expected Behavior

I expect to be notified of an invalid --since-commit input

Actual Behavior

It finishes successfully with no chunks or bytes.

Steps to Reproduce

  1. cd to any git repository
  2. run trufflehog git --since-commit=THISISPROBABLYINVALID file://.

Environment

  • OS: macOS
  • Version 15.0.1 (24A348)
@JonZeolla JonZeolla added the bug label Oct 10, 2024
@sahil9001 sahil9001 mentioned this issue Oct 15, 2024
Open
2 tasks
@sahil9001
Copy link
Contributor

@JonZeolla I have raised a PR, please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JonZeolla @sahil9001