Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with incorrect verification endpoint and verification logic for BrandFetch #3469

Open
sahil9001 opened this issue Oct 18, 2024 · 0 comments · May be fixed by #3470
Open

Issue with incorrect verification endpoint and verification logic for BrandFetch #3469

sahil9001 opened this issue Oct 18, 2024 · 0 comments · May be fixed by #3470
Labels

Comments

@sahil9001
Copy link
Contributor

sahil9001 commented Oct 18, 2024

Please review the Community Note before submitting

TruffleHog Version

Trace Output

Expected Behavior

The API endpoint should point to v2 API with correct validation logic for token.

Reference : https://docs.brandfetch.com/reference/brand-api

Actual Behavior

Issue 1: Incorrect verification endpoint

Currently the API endpoint for verification points to https://api.brandfetch.io/v1/color which is nowhere to be found on the brandfetch.io documentation. They have upgraded to v2 apis.

Issue 2: Incorrect validation logic

Currently the verification logic for the token is incorrect, which is according to the v1 APIs which doesn't work anymore.

Steps to Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Environment

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional Context

References

  • #0000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

1 participant