Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with incorrect verification endpoint and validation logic for browshot detector #3473

Open
sahil9001 opened this issue Oct 18, 2024 · 0 comments · May be fixed by #3474
Open

Issue with incorrect verification endpoint and validation logic for browshot detector #3473

sahil9001 opened this issue Oct 18, 2024 · 0 comments · May be fixed by #3474
Labels

Comments

@sahil9001
Copy link
Contributor

Please review the Community Note before submitting

TruffleHog Version

Trace Output

Expected Behavior

Issue 1 : Correct Verification Endpoint

Verification endpoint can be fixed to point to https://api.browshot.com/api/v1/account/info which is aligned with the documentation to fetch the account info and also with other detector's logic.

Reference : https://browshot.com/api/documentation#account_info

Issue 2 : Correct validation logic for token

The key size should be 32 instead of 28.
Screenshot 2024-10-19 at 1 54 35 AM

Actual Behavior

Issue 1 : Incorrect Verification endpoint

Currently the API verification endpoint points to https://api.browshot.com/api/v1/instance/list.

Issue 2 : Incorrect validation logic for token

Currently the regex is of 28 characters, which is not valid for current API keys provided by browshot.
Screenshot 2024-10-19 at 1 54 20 AM

Steps to Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Environment

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional Context

References

  • #0000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

1 participant