-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
question: possible contributions - binary installation location #20
Comments
Hi @zettlrobert! Thanks for reaching out! Short answer: Yes, that all sounds great!Long answer:Bundled installI definitely get the motivation here, and our VSCode extension (which this is designed to replace/mimic) auto installs the binary for you. In this case, we would probably want 2 fields, such as:
MasonI haven't used Mason before, but that's definitely a good suggestion. I'll have to look more into their specifics, but we provide our launcher as an npm package here. Null-lsAlthough I haven't used it before, I suspect ContributionsWhile the |
Hi @TylerJang27 i appreciate your answer! My first step will be to sort out a local installation get everything setup and take a look on how and if all the tooling works together. If I find the time and decide to implement the above integrations. I will come back with a draft/proposal to brainstorm on. Thanks again for the Long Answer your time and effort are really appriciated! |
Sounds good! Let me know if you need any help getting it set up. Note that the current implementation (as you saw) requires Auto installing the binary definitely aligns with our goals for this plugin, so we'd love to have it! |
TLDR - Contribution Guidelines? Open for PRs?
Current Preference
I have a setup that installs some default lsps, formatters and other required binaries into the nvim specific
$HOME/.local/share/nvim
directory, independently from similar binaries on my system.An additional lsp should follow that convenience
Feature Idea
Would you be open to prs that provide a config flag for example
auto_install_prerequisites
/auto_install_binary
or similar to have a 'bundled' experience.How and if the global and scoped versions could share the cache (
$HOME/.cache/trunk
) is something that I would have to look into.Or even a Mason integration?
Reasoning
I personally like for my 'editor' to be able to install all servers and required binaries without messing with 'global' packages and path (keep the non project related path as small as possible).
Variables local binaries as well as systems constraints could change over time and projects - (disregarding containerized development and nix-shell or similar for the sake of the argument).
Generic Setup Question
Additional Question before I try out the plugin.
Do you suggest disabling for example
null-ls
or none-ls as they seem to provide the same or at least similar functionality with there own implementationBest Regards
The text was updated successfully, but these errors were encountered: