feat: TimePicker component #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It had no effect and would have added confusion. Just don't set the prop as it is optional, instead
brandonlenz
requested review from
ahobson,
gidjin,
haworku,
sarboc,
SirenaBorracha,
suzubara and
tinyels
as code owners
brandonlenz
changed the title
|
I'm gonna be honest, I added the ability to add the data-filter props in 18ecb03, but I'm really not sure if that's necessary. It doesn't seem to impact the functionality of this component at all (at least in the react version). Those props are added to the USWDS component, and can be seen in the markup, I just don't know if they actually do anything, or what their purpose is. We can easily revert 18ecb03 if these are not deemed to be needed. |
|
Created #1108 to fix filtering with the current iteration of TimePicker. It will not be a breaking change to fix, but in the interest of unblocking the 2.10.0 work in flight I wanted to remove that dependency from this PR. |
Merged
brandonlenz
added a commit
that referenced
this pull request
Apr 12, 2021
## [1.15.0](1.14.0...1.15.0) (2021-04-12) ### Features * Identifier component ([#1044](#1044)) ([e79bc87](e79bc87)) * StepIndicator component ([#1047](#1047)) ([d61988e](d61988e)) * TimePicker component ([#1082](#1082)) ([c7bfdee](c7bfdee)) * Update to USWDS 2.9.0 ([#1048](#1048)) ([3859eea](3859eea)) ### Documentation & Examples * Add guidance for PR titles and testing in an application ([#1028](#1028)) ([be3bed4](be3bed4))
brandonlenz
added a commit
that referenced
this pull request
May 12, 2021
brandonlenz
added a commit
that referenced
this pull request
May 12, 2021
## [1.15.0](1.14.0...1.15.0) (2021-04-12) ### Features * Identifier component ([#1044](#1044)) ([e79bc87](e79bc87)) * StepIndicator component ([#1047](#1047)) ([d61988e](d61988e)) * TimePicker component ([#1082](#1082)) ([c7bfdee](c7bfdee)) * Update to USWDS 2.9.0 ([#1048](#1048)) ([3859eea](3859eea)) ### Documentation & Examples * Add guidance for PR titles and testing in an application ([#1028](#1028)) ([be3bed4](be3bed4))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the USWDS TimePicker component
Related Issues or PRs
closes: #738
How To Test
Screenshots (optional)
Default:
Min and max times:
