Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Implement Identifier Subcomponents #1100

Closed
brandonlenz opened this issue Apr 7, 2021 · 0 comments · Fixed by #1138
Closed

[feat] Implement Identifier Subcomponents #1100

brandonlenz opened this issue Apr 7, 2021 · 0 comments · Fixed by #1138
Assignees
Labels
type: feature New feature or request
Milestone

Comments

@brandonlenz
Copy link
Contributor

Does your feature request relate to a specific USWDS component?

Identifier

What USWDS Version is this feature present in?

2.9.0

Is your feature request related to a problem? Please describe.

As per #1044 (comment), an enhancement for the MVP of identifier would include out-of-the-box subcomponents for IdentifierContainer, IdentifierLogos, IdentifierAgencyDescription

Describe the solution you'd like

  1. Create the subcomponents required to best encapsulate the uswds classes instead of requiring consumers to manually implement these.
  2. Update the storybook examples to include these subcomponents.

Describe alternatives you've considered

I think we have consensus around this change, I'll just say to use judgement/discussion to determine how deeply these subcomponents should be implemented and exposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants