Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add nav variant to Link #166

Closed
suzubara opened this issue May 18, 2020 · 3 comments
Closed

feat: Add nav variant to Link #166

suzubara opened this issue May 18, 2020 · 3 comments
Assignees
Labels
good first issue Good for newcomers type: feature New feature or request

Comments

@suzubara
Copy link
Contributor

suzubara commented May 18, 2020

We have an existing Link component that should be adjusted to handle a new variant prop called nav.

Requirements:

  • Add nav as another possible value to the StyledLinkProps variant type definition
  • Adjust the logic in the linkClasses function so that it includes the usa-nav__link class when the variant prop is nav
  • Add a storybook example to Link.stories.tsx for <Link variant="nav">
@suzubara suzubara added the status: needs requirements This issue is NOT ready for development - it needs further scope clarification or questions answered label May 19, 2020
@haworku
Copy link
Contributor

haworku commented Jul 16, 2020

This could be accomplished by adding a navLink variant to the new <Link /> #309 Renamed the issue to reflect that.

@haworku haworku added good first issue Good for newcomers and removed status: needs requirements This issue is NOT ready for development - it needs further scope clarification or questions answered labels Jul 16, 2020
@haworku haworku changed the title Proposal: NavLink component feat: Add nav variant to Link Jul 21, 2020
@SirenaBorracha
Copy link
Contributor

@suzubara or @haworku could you please review and let me know if anything looks off? Otherwise I'll put up a PR. My branch: https://github.com/trussworks/react-uswds/tree/ak-feat-add-nav-variant-to-link-166

Screen Shot 2021-02-03 at 2 49 27 PM

@haworku
Copy link
Contributor

haworku commented Feb 3, 2021

@SirenaBorracha hello, new contributor 😄

The ternary looks close but I think there's a change we still need. It is easier to discuss if we can comment on the code diff directly in a PR rather than here in an issue away from the code. Go ahead and open a PR from your branch. You can make a "draft" PR and/or you can put the yellow "wip" work in progress label on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants