-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add nav
variant to Link
#166
Comments
This could be accomplished by adding a |
@suzubara or @haworku could you please review and let me know if anything looks off? Otherwise I'll put up a PR. My branch: https://github.com/trussworks/react-uswds/tree/ak-feat-add-nav-variant-to-link-166 |
@SirenaBorracha hello, new contributor 😄 The ternary looks close but I think there's a change we still need. It is easier to discuss if we can comment on the code diff directly in a PR rather than here in an issue away from the code. Go ahead and open a PR from your branch. You can make a "draft" PR and/or you can put the yellow "wip" work in progress label on it. |
We have an existing
Link
component that should be adjusted to handle a newvariant
prop callednav
.Requirements:
nav
as another possible value to theStyledLinkProps
variant
type definitionlinkClasses
function so that it includes theusa-nav__link
class when thevariant
prop isnav
Link.stories.tsx
for<Link variant="nav">
The text was updated successfully, but these errors were encountered: