Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] 2.4.0 includes type definitions for unreleased components #1726

Closed
suzubara opened this issue Oct 29, 2021 · 1 comment
Closed

[fix] 2.4.0 includes type definitions for unreleased components #1726

suzubara opened this issue Oct 29, 2021 · 1 comment
Assignees
@suzubara
Labels
type: bug Something isn't working like it's supposed to

Comments

@suzubara
Copy link
Contributor

ReactUSWDS Version & USWDS Version:

ReactUSWDS 2.4.0 includes type definitions in the package tar for components that are not a part of the actual release (/lib/components/IconList). This is causing some TypeScript compilation errors for my application in CI, I think due to the path being ambiguous/similar to the definitions located at /lib/components/Icons.
@suzubara suzubara added the type: bug Something isn't working like it's supposed to label Oct 29, 2021
@suzubara suzubara self-assigned this Oct 29, 2021
@suzubara suzubara mentioned this issue Oct 29, 2021
Merged
@suzubara
Copy link
Contributor Author

Fixed by #1727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suzubara suzubara

Labels
type: bug Something isn't working like it's supposed to
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@suzubara